Fix issue #875: Reorder IfExp fields to match evaluation order#1441
Open
rylena wants to merge 1 commit intoInstagram:mainfrom
Open
Fix issue #875: Reorder IfExp fields to match evaluation order#1441rylena wants to merge 1 commit intoInstagram:mainfrom
rylena wants to merge 1 commit intoInstagram:mainfrom
Conversation
meta-cla
bot
added
the
CLA Signed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #875 by reordering the fields of
IfExptobody, test, orelse.This matches the Python syntax order (
body if test else orelse) and the logical evaluation order.Previously, the order was
test, body, orelse, which causedrepr(node)to be confusing and inconsistent with visitor order (which was already correct).Changes:
IfExpfields inlibcst/_nodes/expression.py._visit_and_replace_childreninIfExpto match new order.libcst/_nodes/tests/test_ifexp.pyto use new field order in positional arguments.python -m libcst.codegen.generate allto update generated matchers and visitors.